Conversation
Contributor
Author
|
@Fabio1988 Nope! I had no chance and won't have any for another few weeks. It would be good to bring back our stagging for tests. |
lenisko
force-pushed
the
len-missing-metrics
branch
from
7d83f44 to
682488d
Compare
Collaborator
Contributor
Author
|
@Fabio1988 Tested on HTTP connection (no issues), I don't use gRPC, yet. So if someone is willing to check - would be great. Updated with |
Collaborator
You don't use grpc from dragonite? The json format is more cpu intensive on both sides |
Contributor
Author
|
I'm aware! missing metrics made me pick json. hehe. |
Collaborator
|
sounds like a good time to test the metrics then, and then we can merge |
Contributor
Author
|
That's the plan. Will do later today and merge if it's okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IncRawRequestswasn't incremented